Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra button from Restart Kernel modal #10539

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Remove extra button from Restart Kernel modal #10539

merged 3 commits into from
Jun 22, 2022

Conversation

kilacoda
Copy link
Contributor

Fixes #10536

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@kilacoda kilacoda requested a review from a team as a code owner June 22, 2022 19:05
@kilacoda kilacoda mentioned this pull request Jun 22, 2022
Closed
2 tasks
@rchiodo
Copy link
Contributor

rchiodo commented Jun 22, 2022

You should probably add a news entry. Don't forget to thank yourself :)

@ghost
Copy link

ghost commented Jun 22, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@kilacoda
Copy link
Contributor Author

Haha, didn't know if it's worth a news entry or not so was shying away from it 😅

@codecov-commenter
Copy link

Codecov Report

Merging #10539 (3e5823c) into main (f274826) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #10539   +/-   ##
======================================
- Coverage     71%      71%   -1%     
======================================
  Files        465      465           
  Lines      27905    27904    -1     
  Branches    4699     4699           
======================================
- Hits       19843    19828   -15     
- Misses      6188     6200   +12     
- Partials    1874     1876    +2
Impacted Files Coverage Δ
src/notebooks/notebookCommandListener.ts 53% <ø> (+1%) ⬆️
src/kernels/errors/jupyterInvalidKernelError.ts 62% <0%> (-38%) ⬇️
src/platform/common/cancellation.ts 59% <0%> (-10%) ⬇️
.../standalone/survey/dataScienceSurveyBanner.node.ts 66% <0%> (-6%) ⬇️
...rc/kernels/debugger/debugLocationTrackerFactory.ts 96% <0%> (-4%) ⬇️
src/kernels/jupyter/session/jupyterSession.ts 72% <0%> (-3%) ⬇️
...ebooks/controllers/notebookIPyWidgetCoordinator.ts 87% <0%> (-2%) ⬇️
src/kernels/execution/cellExecutionQueue.ts 81% <0%> (-2%) ⬇️
src/kernels/variables/kernelVariables.ts 56% <0%> (-2%) ⬇️
src/platform/common/process/baseDaemon.node.ts 50% <0%> (-2%) ⬇️
... and 11 more

@rchiodo rchiodo merged commit 380e100 into microsoft:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra Cancel button on restart kernel modal window
3 participants
@kilacoda @rchiodo @codecov-commenter